Skip to content

Clarified Attribute Option already exists response #39941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from
Open

Clarified Attribute Option already exists response #39941

wants to merge 2 commits into from
+7 −7

Conversation

J0rdyV
Copy link

@J0rdyV J0rdyV commented May 27, 2025 •
edited by m2-assistant bot
Loading

Description (*)

Replaced the awkward phrase "Get new file name if the same is already exists" with a clearer and grammatically correct version: "Get a new file name if one already exists." This improves readability and user understanding.
Same for the attribute option response.

Manual testing scenarios (*)

  1. pushing an already existing attribute option to the attribute option api endpoint.

Questions or comments

First time PR to Magento. Please let me know if i need to do something else.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Clarified Attribute Option already exists response #39943: Clarified Attribute Option already exists response

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented May 27, 2025

Hi @J0rdyV. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@J0rdyV
Copy link
Author

J0rdyV commented May 27, 2025

@magento run all tests

@engcom-Hotel engcom-Hotel added the Priority: P3 May be fixed according to the position in the backlog. label May 27, 2025
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard May 27, 2025
@engcom-Hotel
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request May 27, 2025
Closed
5 tasks
lbajsarowicz
lbajsarowicz approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ It's just a typo.

@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Pending Review to Ready for Testing in Pull Requests Dashboard May 27, 2025
@J0rdyV
Copy link
Author

J0rdyV commented Aug 12, 2025

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: pending review Progress: ready for testing
Projects
Pull Requests Dashboard
Status: Ready for Testing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Clarified Attribute Option already exists response
3 participants
@J0rdyV @engcom-Hotel @lbajsarowicz